[MooreToCore] Lower moore.real_constant to arith.constant
#9100
+88
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-lower-real-constant
branch
from
4410add to
a6974cc
Compare
fabianschuiki
approved these changes
Oct 16, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Really nice! Just a few nits, LGTM otherwise 🥳
Scheremo
force-pushed
the
pr-lower-real-constant
branch
5 times, most recently
from
6ba6eac to
6727d00
Compare
This commit introduces explicit support for `shortreal` literals in the Moore dialect and unifies the lowering and import handling of real constants. It ensures correct mapping between SystemVerilog `real`/`shortreal` and MLIR `f64`/`f32` types across all relevant conversions. Changes: Dialect (MooreOps.td): - Added `ShortrealLiteralOp`: - Accepts `F32Attr` and produces `RealF32`. - Represents IEEE-754 single-precision (SystemVerilog `shortreal`). - Updated `RealLiteralOp`: - Now explicitly uses `F64Attr` and produces `RealF64`. - Simplified `assemblyFormat` by removing redundant result type. - Clarified description to indicate IEEE-754 double precision. ImportVerilog (Expressions.cpp): - Updated `materializeSVReal`: - Emits `ShortrealLiteralOp` for `shortreal` values. - Emits `RealLiteralOp` for `real` values. - Uses appropriate `FloatAttr` construction and result type selection. MooreToCore Conversion (MooreToCore.cpp): - Added conversion patterns: - `RealConstantOpConv` → lowers to `arith.constant` with `f64` type. - `ShortrealConstantOpConv` → lowers to `arith.constant` with `f32` type. - Marked `arith::ArithDialect` as legal. - Extended `TypeConverter` to map: - `moore::RealWidth::f32` → `mlir::Float32Type` - `moore::RealWidth::f64` → `mlir::Float64Type` Tests: - Updated `ImportVerilog` tests to expect `moore.shortreal_constant` and `moore.real_constant` without explicit result type suffixes. - Added `MooreToCore` tests verifying correct lowering: - `moore.real_constant` → `arith.constant f64` - `moore.shortreal_constant` → `arith.constant f32`
Scheremo
force-pushed
the
pr-lower-real-constant
branch
from
6727d00 to
79bfefe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces explicit support for
shortrealliterals in the Moore dialect and unifies the lowering and import handling of real constants. It ensures correct mapping between SystemVerilogreal/shortrealand MLIRf64/f32types across all relevant conversions.Changes:
Dialect (MooreOps.td):
ShortrealLiteralOp:F32Attrand producesRealF32.shortreal).RealLiteralOp:F64Attrand producesRealF64.assemblyFormatby removing redundant result type.ImportVerilog (Expressions.cpp):
materializeSVReal:ShortrealLiteralOpforshortrealvalues.RealLiteralOpforrealvalues.FloatAttrconstruction and result type selection.MooreToCore Conversion (MooreToCore.cpp):
RealConstantOpConv→ lowers toarith.constantwithf64type.ShortrealConstantOpConv→ lowers toarith.constantwithf32type.arith::ArithDialectas legal.TypeConverterto map:moore::RealWidth::f32→mlir::Float32Typemoore::RealWidth::f64→mlir::Float64TypeTests:
ImportVerilogtests to expectmoore.shortreal_constantandmoore.real_constantwithout explicit result type suffixes.MooreToCoretests verifying correct lowering:moore.real_constant→arith.constant f64moore.shortreal_constant→arith.constant f32