[FIRRTL] Add LowerDomains to firtool pipeline #9099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the LowerDomains to the low FIRRTL to HW pipeline inside firtool. This is the latest position in which it can run as it has a hard dependency on needing to run before LowerClasses. This is not conditionalized with a chicken switch option as this pass will eventually be required for correctness and it is a no-op if no domain information exists in the circuit. Signed-off-by: Schuyler Eldridge <[email protected]>
dtzSiFive
approved these changes
Oct 16, 2025
Contributor
dtzSiFive
left a comment
dtzSiFive
left a comment
There was a problem hiding this comment.
LGTM, thanks for the nice PR description and test!
Member
Author
|
One note: don't try to do anything interesting involving multiple modules and Edit: trivial fix for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the LowerDomains to the low FIRRTL to HW pipeline inside firtool.
This is the latest position in which it can run as it has a hard
dependency on needing to run before LowerClasses.
This is not conditionalized with a chicken switch option as this pass will
eventually be required for correctness and it is a no-op if no domain
information exists in the circuit.