[LLHD] Remove unused passes and unused memory types and ops #9078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
force-pushed
the
fschuiki/llhd-dce
branch
from
ebd0ebb to
ee65c0f
Compare
The circt-verilog pipeline uses only a subset of the passes in the LLHD dialect. A few of the passes have been superseded by a reworked version which currently coexists with the original pass. Remove the old passes. We also don't use the LLHD `PtrType` and the related operations anywhere in CIRCT. It looks like SV and VHDL are going to be easier to model if we treat everything as a signal, but have blocking assignments to model the behavior of variables. Remove these ops and the pointer type.
fabianschuiki
force-pushed
the
fschuiki/llhd-dce
branch
from
ee65c0f to
a14a76b
Compare
Scheremo
approved these changes
Oct 10, 2025
Contributor
Scheremo
left a comment
Scheremo
left a comment
There was a problem hiding this comment.
LGTM. Just one mega nit:
The block diagram docs/dialects.drawio still refers to Desequentialization in arrow 8.
Otherwise the removal seems quite thorough to me.
Contributor
Author
|
Good point! I guess we still have the Deseq pass, but it might make sense to adjust the name in the diagram to match that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The circt-verilog pipeline uses only a subset of the passes in the LLHD dialect. A few of the passes have been superseded by a reworked version which currently coexists with the original pass. Remove the old passes.
We also don't use the LLHD
PtrTypeand the related operations anywhere in CIRCT. It looks like SV and VHDL are going to be easier to model if we treat everything as a signal, but have blocking assignments to model the behavior of variables. Remove these ops and the pointer type.