[Comb] Fix mux canonicalizers for non-signless-ints #9071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few of the mux canonicalizers assumed signless integers, which is not always the case. Detect when this is not the case and disable those canonicalizations. Fixes #9043.
Contributor
Author
|
@uenoku if you see any problems with this patch (i.e. it disables things too broadly) feel free to make changes directly to my branch. |
uenoku
approved these changes
Oct 8, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
LGTM! Thank you for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the mux canonicalizers assumed signless integers, which is not always the case. Detect when this is not the case and disable those canonicalizations.
Fixes #9043.