Skip to content

Conversation

@teqdruid
Copy link
Contributor

@teqdruid teqdruid commented Oct 6, 2025

Reduces the amount of space assigned to each MMIO client to 1k (which fits 128 64-bit registers). Deals with manifest reads correctly.

@teqdruid teqdruid requested a review from Copilot October 6, 2025 23:19
@teqdruid teqdruid added the ESI label Oct 6, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reduces the MMIO space allocated per client from 1MB to 1KB (128 64-bit registers) and improves manifest ROM handling. The changes optimize memory usage while ensuring proper address decoding for both regular clients and manifest reads.

  • Updated MMIO space constants from 0x100000 to 0x400 (1KB per client)
  • Enhanced address decoding logic to handle manifest reads separately from regular client access
  • Removed TODO comment about insufficient address space for large compressed manifests

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Reduces the amount of space assigned to each MMIO client to 1k (which
fits 128 64-bit registers). Deals with manifest reads correctly.
@teqdruid teqdruid force-pushed the teqdruid/mmio-smaller branch from 6381e5b to 748d4cf Compare October 6, 2025 23:23
@teqdruid teqdruid merged commit fbc6bb4 into main Oct 6, 2025
7 checks passed
@teqdruid teqdruid deleted the teqdruid/mmio-smaller branch October 6, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants