[circt-verilog-lsp] Minimize project-scope File IO #9056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-lsp-projectdriver
branch
3 times, most recently
from
fc58142 to
3e93c5f
Compare
uenoku
approved these changes
Oct 8, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Question on shared pointer but otherwise LGTM
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogDocument.cpp
Outdated
Show resolved
Hide resolved
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogTextFile.cpp
Show resolved
Hide resolved
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogTextFile.h
Outdated
Show resolved
Hide resolved
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogDocument.cpp
Outdated
Show resolved
Hide resolved
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogDocument.cpp
Outdated
Show resolved
Hide resolved
Scheremo
force-pushed
the
pr-lsp-projectdriver
branch
from
18429d7 to
ebf4c6d
Compare
Reduce filesystem I/O overhead caused by repeated re-opening and reparsing of project files in the Verilog LSP server when using the `-C` option. For a large, SoC-scale project this approach reduces parsing time from ~1s to 0.75s. This implementation also correctly indexes the editor-state rather than the file system state of the main buffer. - **Introduced shared `projectDriver`:** A persistent `slang::driver::Driver` is now created once per project and passed to all `VerilogDocument` instances to reuse loaded files and avoid redundant disk access. - **Refactored `VerilogDocument` initialization:** - Removed per-buffer command file parsing and main-file filtering logic. - Added `setTopModules()` and `copyBuffers()` helpers to extract top-level modules and reuse in-memory buffers from `projectDriver` instead of reading from disk. - **Inheritance of project context:** - Copied defines/undefines directly from the shared driver. - Added placeholder for include path copying (TODO). - Library search directories are now applied once at construction. - **VerilogTextFile integration:** - Added `initializeProjectDriver()` to parse all command files once and hold a shared driver reference for reuse.
Scheremo
force-pushed
the
pr-lsp-projectdriver
branch
from
ebf4c6d to
bafc2ae
Compare
Contributor
Author
Thanks for the review! I think I addressed the points you raised, but I'll keep this open for a day or so before merging, just in case you'd like to have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce filesystem I/O overhead caused by repeated re-opening and reparsing of project files in the Verilog LSP server when using the
-Coption. For a large, SoC-scale project this approach reduces parsing time from ~1s to 0.75s.This implementation also correctly indexes the editor-state rather than the file system state of the main buffer.
projectDriver: A persistentslang::driver::Driveris now created once per project and passed to allVerilogDocumentinstances to reuse loaded files and avoid redundant disk access.VerilogDocumentinitialization:setTopModules()andcopyBuffers()helpers to extract top-level modules and reuse in-memory buffers fromprojectDriverinstead of reading from disk.initializeProjectDriver()to parse all command files once and hold a shared driver reference for reuse.