[circt-verilog-lsp][NFC] Break out implementation classes #9051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-lsp-refactor
branch
4 times, most recently
from
63f153a to
ec56444
Compare
Scheremo
force-pushed
the
pr-lsp-refactor
branch
from
ec56444 to
7b574fc
Compare
Scheremo
force-pushed
the
pr-lsp-refactor
branch
from
7b574fc to
6259965
Compare
uenoku
reviewed
Oct 5, 2025
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/LSPDiagnosticClient.h
Outdated
Show resolved
Hide resolved
uenoku
approved these changes
Oct 5, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Please replace #pragma once with macro based header guards as it's non-standard feature unfortunately. Otherwise LGTM.
uenoku
reviewed
Oct 5, 2025
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/LSPDiagnosticClient.cpp
Show resolved
Hide resolved
Contributor
Author
Fixed the nit and |
Scheremo
force-pushed
the
pr-lsp-refactor
branch
from
504db3f to
22fda4b
Compare
**Summary** - Refactored `VerilogServerImpl` into smaller, well-structured components for clarity, testability, and maintainability. - Moved large inline class implementations out of `VerilogServer.cpp` into dedicated compilation units. **Changes** - **New modules** - `VerilogTextFile`: manages LSP file contents, versioning, and incremental updates. - `VerilogDocument`: handles Slang integration, parsing, diagnostics, and indexing setup. - `VerilogIndex`: implements symbol/reference tracking using interval maps. - `LSPDiagnosticClient`: converts Slang diagnostics to LSP diagnostics. - `VerilogServerContext`: stores server-wide options and shared configuration. - **Refactors** - `VerilogServer`: simplified to a coordinator using the pImpl pattern and `VerilogTextFile` instances. - Removed large class definitions (Document, Index, DiagnosticClient, etc.) from `VerilogServer.cpp`. - Updated `CMakeLists.txt` to compile new files. - **Headers** - Added clear LLVM-style header comments. - Reduced includes and replaced them with forward declarations where possible. **Impact** - No functional changes; purely structural refactor. - Improved code organization and readability. - Enables independent testing and clearer layering between LSP, Slang, and CIRCT logic.
Scheremo
force-pushed
the
pr-lsp-refactor
branch
from
22fda4b to
00efd2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
VerilogServerImplinto smaller, well-structured components for clarity, testability, and maintainability.VerilogServer.cppinto dedicated compilation units.Changes
VerilogTextFile: manages LSP file contents, versioning, and incremental updates.VerilogDocument: handles Slang integration, parsing, diagnostics, and indexing setup.VerilogIndex: implements symbol/reference tracking using interval maps.LSPDiagnosticClient: converts Slang diagnostics to LSP diagnostics.VerilogServerContext: stores server-wide options and shared configuration.VerilogServer: simplified to a coordinator using the pImpl pattern andVerilogTextFileinstances.VerilogServer.cpp.CMakeLists.txtto compile new files.Impact