[circt-verilog-lsp] Add support for package import indexing #9023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scheremo
force-pushed
the
pr-lsp-extensions
branch
from
6a0bb8c to
aff3a2f
Compare
Scheremo
force-pushed
the
pr-lsp-extensions
branch
from
aff3a2f to
fed091f
Compare
uenoku
approved these changes
Sep 25, 2025
lib/Tools/circt-verilog-lsp-server/VerilogServerImpl/VerilogServer.cpp
Outdated
Show resolved
Hide resolved
…rver.cpp Co-authored-by: Hideto Ueno <[email protected]>
Contributor
Author
Could you merge this for me? I still don't have commit access 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this PR adds support for looking up the definition of package imports, tests included 😄