[ESI] Allow single-file additions to SourceFiles #9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend `SourceFiles` to also allow single file additions to the source file list. Small, but important addition, due to the perniciousness of verilog compilers(/simulators), in that e.g. type-files have to have a strict ordering when they have inter-dependencies. Just scanning a directory and adding them in lexical order may or may not (...obviously) cause problems in that aspect. With this change, gives users control over the order in which these files are added to the source list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend
SourceFilesto also allow single file additions to the source file list.Small, but important addition, due to the perniciousness of verilog compilers(/simulators), in that e.g. type files have to have a strict ordering when they have inter-dependencies. Just scanning a directory and adding them in lexical order may or may not (...obviously) cause problems in that aspect. With this change, gives users control over the order in which these files are added to the source list.