[circt-test] accept LoweringOptions to control the generated Verilog #9001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since SBY doesn't support all System Verilog constructs, it's useful to be able to control how lowering is done. We may e.g. pass `disallowLocalVariables` when using SBY as a runner. Ideally, this would be more automated (i.e. automatically pick a set of lowering options that is known to work for the specific runner), but that would be a bigger change since the different runners would then require different lowering. We also don't currently have all the lowering options we would need for this.
fabianschuiki
approved these changes
Sep 23, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Very nice, thanks for adding this! Do you want me to land this for you, or do you have commit access yourself?
Contributor
Author
|
Thanks for the review. I don't have commit access, so it would be great if you landed my PRs for me. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SBY doesn't support all System Verilog constructs, it's useful to be able to control how lowering is done. We may e.g. pass
disallowLocalVariableswhen using SBY as a runner.Ideally, this would be more automated (i.e. automatically pick a set of lowering options that is known to work for the specific runner), but that would be a bigger change since the different runners would then require different lowering. We also don't currently have all the lowering options we would need for this.