[Datapath] Add product of sum partial product operator #8980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
approved these changes
Sep 18, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Looks awesome! Could you add LEC tests as well?
uenoku
reviewed
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the work of Zimmerman we can implement expressions of the form: (a+b)*c, namely a multiplier where one of the operands is in a carry-save format. This can be useful if we want to multiply three numbers together for example.
Specifically we can use a special encoding to avoid computing the complete (carry-propagated) result of (a+b) before we start the multiplication. This PR adds the following operator:
The PR includes lowerings to comb gates and to SMT for verification as well as canonicalization patterns.