[Synth] Rename FanIn/FanOut StartPoint/EndPoint

[markram1729]

Resolves #8967

[uenoku]

Thank you! 🙏🙏🙏 Could you change python bindings/tests as well?

[markram1729]

Thank you! 🙏🙏🙏 Could you change python bindings/tests as well?

Sure!

[uenoku]

nit: it's a bit tedious but could you use "start point" in the non code part?

Suggested change

	// An OpenPath represents a path from a startPoint with an associated
	// An OpenPath represents a path from a start point with an associated

[markram1729]

sure!

[markram1729]

Hi @uenoku , I have resolved as mentioned

I am having issue at

circt/test/Dialect/Synth/longest-paths-report.mlir

Line 42 in 49dc29c

// JSON-SAME{LITERAL}: "start_point":{"bit_pos":0,"instance_path":[],"name":"a"},

How can i make this check with JSON-SAME{LITERAL} , I set the order after history because
Json is emitting lexographically

fan_in used to emit before history
now start_point emits after history []

can you suggest how can i resolve this

also please suggest if i need to change anything at PrintLongestPathAnalysis.cpp

[uenoku]

It seems the following works. You can just remove trailing commas.

diff --git a/test/Dialect/Synth/longest-paths-report.mlir b/test/Dialect/Synth/longest-paths-report.mlir
index a3e76500f..19cac028c 100644
--- a/test/Dialect/Synth/longest-paths-report.mlir
+++ b/test/Dialect/Synth/longest-paths-report.mlir
@@ -37,10 +37,10 @@
 // JSON-SAME{LITERAL}:    [{"level":1,"count":1,"percentage":50},
 // JSON-SAME{LITERAL}:     {"level":2,"count":1,"percentage":100}]
 // JSON-SAME{LITERAL}:    "top_paths":[
-// JSON-SAME{LITERAL}:     {"end_point":{"bit_pos":0,"instance_path":[],"name":"y"},
-// JSON-SAME{LITERAL}:      "path":{"delay":2,"history":[{"comment":"output port","delay":2,"object":{"bit_pos":0,"instance_path":[],"name":"c2.x"}},
-// JSON-SAME{LITERAL}:      "start_point":{"bit_pos":0,"instance_path":[],"name":"a"},
-// JSON-SAME{LITERAL}:      "root":"parent"},
+// JSON-SAME{LITERAL}:     {"end_point":{"bit_pos":0,"instance_path":[],"name":"y"}
+// JSON-SAME{LITERAL}:      "path":{"delay":2,"history":[{"comment":"output port","delay":2,"object":{"bit_pos":0,"instance_path":[],"name":"c2.x"}}
+// JSON-SAME{LITERAL}:      "start_point":{"bit_pos":0,"instance_path":[],"name":"a"}
+// JSON-SAME{LITERAL}:      "root":"parent"
 // Make sure the second path is reported.
 // JSON-SAME{LITERAL}:     {"end_point":{"bit_pos":0,"instance_path":[],"name":"x"},
 

[uenoku]

LGTM, really thank you for doing this!