[ESI] Factor out inner execution in Simulator::run #8964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using esi-cosim as a library, it is very inconvenient that the default behavior of the `run` command assumes that `esi-cosim` is executed as a standalone script (i.e. either tries to run a user-provided command or waits for user input). To better serve as a library, factor out the inner simulator process execution to `run_proc` s.t. other python code can call this, and get a handle to the simulator process and port.
teqdruid
approved these changes
Sep 16, 2025
Contributor
teqdruid
left a comment
teqdruid
left a comment
There was a problem hiding this comment.
Looks good to me. Just make one of the two modifications I gave.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using esi-cosim as a library, it is very inconvenient that the default behavior of the
runcommand assumes thatesi-cosimis executed as a standalone script (i.e. either tries to run a user-provided command or waits for user input). To better serve as a library, factor out the inner simulator process execution torun_procs.t. other python code can call this, and get a handle to the simulator process and port.