[Reduce] Use stable sort, prune unused symbols, tweak FIRRTL reductions #8938
+118
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
added
FIRRTL
fabianschuiki
force-pushed
the
fschuiki/firrtl-reduce-tweaks
branch
from
005d953 to
76921bb
Compare
fabianschuiki
changed the title
fabianschuiki
force-pushed
the
fschuiki/firrtl-reduce-tweaks
branch
from
76921bb to
3eef93c
Compare
uenoku
approved these changes
Sep 10, 2025
uenoku
reviewed
Sep 10, 2025
tools/circt-reduce/circt-reduce.cpp
Outdated
| if (minChunks > 0) | ||
| rangeLength = std::min<size_t>(rangeLength, | ||
| std::max<size_t>(opIdx / minChunks, 1)); | ||
| rangeLength = std::min<size_t>( |
Member
There was a problem hiding this comment.
Could you use std::clamp and llvm::divideCeil?
Contributor
Author
There was a problem hiding this comment.
Nice, let me tweak that! 👍
Use a stable sort in the reducer to sort matches. The binary search over the matchese expects them to be in the order that they were matched in the IR when matches have the same benefit. Add a generic reduction to prune unused symbols. Make the FIRRTL annotation remover check if annotations are already empty, and not match on those ops. This significantly improves reduction speed. Fix an issue in the FIRRTL module externalizer, where `FExtModule`s require an additional list of known layers that needs to be created. Also, don't externalize modules that participate in NLAs, since removing those would invalidate the NLA.
fabianschuiki
force-pushed
the
fschuiki/firrtl-reduce-tweaks
branch
from
3eef93c to
c8ac3ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a stable sort in the reducer to sort matches. The binary search over the matchese expects them to be in the order that they were matched in the IR when matches have the same benefit.
Add a generic reduction to prune unused symbols.
Make the FIRRTL annotation remover check if annotations are already empty, and not match on those ops. This significantly improves reduction speed.
Fix an issue in the FIRRTL module externalizer, where
FExtModules require an additional list of known layers that needs to be created. Also, don't externalize modules that participate in NLAs, since removing those would invalidate the NLA.