Skip to content

[build] Add /utf-8 build if MSVC #8926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seldridge merged 2 commits into from
Sep 5, 2025
Merged

[build] Add /utf-8 build if MSVC #8926

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ff3592
[build] Add /utf-8 build if MSVC
seldridge Sep 5, 2025
27d99ba
fixup! [build] Add /utf-8 build if MSVC
seldridge Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,13 @@ if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )
# Options and settings
#-------------------------------------------------------------------------------

# MSVC-specific compiler configuration
if (MSVC)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /EHs-c- /GR-")
# Enable UTF-8 support for source files and string literals. This is
# required by dependencies like fmt library.
string(APPEND CMAKE_CXX_FLAGS " /utf-8")
string(APPEND CMAKE_C_FLAGS " /utf-8")
else ()
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-exceptions -fno-rtti")
endif ()
Expand Down