[Datapath] Implement timing-driven compression algorithm #8920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and non-timing driven lowerings.
…ectly updated smallVectors
…size of the compressor tree
…sor implementation
uenoku
reviewed
Sep 4, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Looks really awesome! I'll take a closer look tomorrow but high-level:
- Can we remove wallace reduction code path? My understanding is Dadda's algorithm is better even when the input arrival time is uniform, in that case it would be great if we can remove it.
- Probably passing delay via function call back would be cleaner.
Contributor
Author
|
Now with changes recommended including removal of wallace reduction code and using a function call back for delay calculations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on recent updates to incorporate longest path analysis for higher-level dialects (e.g. comb), this PR incorporates the arrival time information into the design of the compressor tree which improves the logic depth of a datpath.compress lowering to AIG. The CompressorTree class was moved into datapath.ops to avoid additional clutter in the comb ops files.
Future PRs will further build upon these algorithms to produce even more efficient compressors.