Skip to content

Conversation

@jpienaar
Copy link
Member

We encountered some failures that were addressed since 9.0 tag, given no API changes seemed like good to bump to new version.

We encountered some failures that were addressed since 9.0 tag, given no
API changes seemed like good to bump to new version.
@fabianschuiki
Copy link
Contributor

Sounds good to me! Thanks for establishing a precedence to pull in up-to-date Slang versions similar to how we bump LLVM 💯

@jpienaar
Copy link
Member Author

@fabianschuiki with this change though I get the following diff which I'm not sure if acceptable/bug introduced
image

From

module GenerateConstructs;
  genvar i;
  parameter p = 2;
  
  generate
    // CHECK: [[TMP:%.+]] = moore.constant 0
    // CHECK: dbg.variable "i", [[TMP]]
    // CHECK: [[TMP:%.+]] = moore.constant 0
    // CHECK: %g1 = moore.variable [[TMP]]
    // CHECK: [[TMP:%.+]] = moore.constant 1
    // CHECK: dbg.variable "i", [[TMP]]
    // CHECK: [[TMP:%.+]] = moore.constant 1
    // CHECK: moore.variable name "g1" [[TMP]]
    for (i = 0; i < 2; i = i + 1) begin
      integer g1 = i;
    end

I can just update the test but unsure if expected.

@fabianschuiki
Copy link
Contributor

That diff looks okay. It seems like Slang now calls unnamed generate blocks genblk, which feels like a reasonable thing to do.

@jpienaar
Copy link
Member Author

Seems the cmake fetch fails if one uses a hash that's not near tip (https://gitlab.kitware.com/cmake/cmake/-/issues/23379), given its opt in, would making it non-shallow be fine?

@jpienaar jpienaar marked this pull request as ready for review August 26, 2025 19:55
@fabianschuiki
Copy link
Contributor

I'm definitely fine with doing a non-shallow fetch. Maybe keep the shallow option as a comment for whenever we switch to a specific version tag?

Copy link
Contributor

@fabianschuiki fabianschuiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is happy 👍 Thanks for keeping us up-to-date with Slang bug fixes!

@jpienaar jpienaar merged commit 998895b into llvm:main Aug 28, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants