[Comb] Generalize AndOp narrowing if mask has leading/trailing zeros #8864
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only narrowing
comb.andoperations that have acomb.extractoperand, do so on any and that has a constant operand with leading or trailing zeros. Since we considercomb.concatto be free, this canonicalization essentially turns a widecomb.andinto a cheaper narrowcomb.andplus an additional, freecomb.concat.This helps canonicalize Comb ops that implement an integer equivalent of
hw.array_injectinto corresponding extracts and concats.In particular, this helps canonicalize
into the more compact