Put memories in the same directory as their parent #8862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By the time lower-to-hw runs, the directories have already been assigned. Colocate the memory module with its parent. Remove logic which would set the output directory to the testbench--this is not always right. This allows memories to be emitted into layer specific directories.
seldridge
approved these changes
Aug 15, 2025
dtzSiFive
approved these changes
Aug 16, 2025
dtzSiFive
reviewed
Aug 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the time lower-to-hw runs, the directories have already been assigned. Colocate the memory module with its parent. Remove logic which would set the output directory to the testbench--this is not always right. This allows memories to be emitted into layer specific directories.