[Support] Use git commit hash as version in non-release builds #8834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of just saying "unknown git version", use the current git commit hash as CIRCT version in non-release builds. This makes the output of `--version` of our tools more useful, because it points to an actual commit. With this change, the [sv-tests-results] website can provide an actual git commit tooltip for the circt-verilog tool being used. [sv-tests-results]: https://chipsalliance.github.io/sv-tests-results/
fabianschuiki
force-pushed
the
fschuiki/git-hash-version
branch
from
5f59b09 to
4c4d91c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just saying "unknown git version", use the current git commit hash as CIRCT version in non-release builds. This makes the output of
--versionof our tools more useful, because it points to an actual commit.With this change, the sv-tests-results website can provide an actual git commit tooltip for the circt-verilog tool being used.