[HWToSMT] Return an unbound value for OOB hw.array_inject #8794
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to 186dcc8. h/t @fzi-hielscher for pointing out the issue
fzi-hielscher
approved these changes
Jul 29, 2025
Contributor
fzi-hielscher
left a comment
fzi-hielscher
left a comment
There was a problem hiding this comment.
Thanks, @uenoku, LGTM.
The verif.refines op should hopefully be able to work with this to have a logical equivalence-like check that also works on OOB cases. But Z3 sometimes refuses to operate on quantified array sorts. So I'll have to tweak the LEC tool first to make sure it properly handles unknown results.
Member
|
It'd probably be a good thing to mention this new OOB behavior in the ODS description field of the op. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to 186dcc8.
h/t @fzi-hielscher for pointing out the issue