[FIRRTL] Make enums behave less like aggregates #8742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes enums behave more like ground types, but doesn't quite take the jump and make them ground types. It removes the ability to index into enum variants using field refs, which was used produce error messages in InferWidths (and enums no longer support having unknown widths). This change adds some helpers to determine the sizes of enumerations. This change modifes InferWidths to to take advantage of the fact that enumerations do not support containing uninferred widths, and removes some dead code. In addition to this, field refs no longer index into the variants of an enum type, so we can handle them in a similar way to ground types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes enums behave more like ground types, but doesn't quite take the jump and make them ground types. It removes the ability to index into enum variants using field refs, which was used produce error messages in InferWidths (and enums no longer support having unknown widths). This change adds some helpers to determine the sizes of enumerations.
This change modifes InferWidths to to take advantage of the fact that enumerations do not support containing uninferred widths, and removes some now dead code. In addition to this, field refs no longer index into the variants of an enum type, so we can handle them in a similar way to ground types.