[AIG] Add slice indexing support to LongestPathCollection in AIG python on bindings #8709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on bindings This commit implements slice indexing functionality for the LongestPathCollection class, allowing users to access multiple timing paths using Python's standard slice notation. The implementation handles all slice types including negative indices, step values, and empty slices through Python's built-in slice.indices() method.
uenoku
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements slice indexing support for the LongestPathCollection class in the AIG Python bindings, allowing users to access multiple timing paths using Python's standard slice notation (e.g., collection[:2] or collection[:-2]).
- Adds slice indexing functionality to the
__getitem__method - Updates type hints to support both integer and slice indices
- Adds test coverage for slice operations including negative indices
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/Bindings/Python/dialects/aig.py | Implements slice indexing in __getitem__ method with updated type hints and documentation |
| integration_test/Bindings/Python/dialects/aig.py | Updates existing test to use slice notation directly and adds negative slice test |
Comment on lines
+293
to
+295
| def __getitem__( | ||
| self, index: Union[slice, | ||
| int]) -> Union[DataflowPath, List[DataflowPath]]: |
There was a problem hiding this comment.
[nitpick] The type annotation formatting should follow PEP 8 style. Consider placing the Union types on the same line or using proper indentation for better readability: index: Union[slice, int]
Suggested change
| def __getitem__( | |
| self, index: Union[slice, | |
| int]) -> Union[DataflowPath, List[DataflowPath]]: | |
| def __getitem__(self, index: Union[slice, int]) -> Union[DataflowPath, List[DataflowPath]]: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements slice indexing functionality for the LongestPathCollection class, allowing users to access multiple timing paths using Python's standard slice notation. The implementation handles all slice types including negative indices, step values, and empty slices through Python's built-in slice.indices() method.