[Datapath] Add Datapath to SMT conversion pass #8682
Merged
+253
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianschuiki
approved these changes
Jul 10, 2025
Contributor
fabianschuiki
left a comment
fabianschuiki
left a comment
There was a problem hiding this comment.
Really cool! Just a few minor test regex nits.
|
|
||
| namespace circt { | ||
|
|
||
| /// Get the HW to SMT conversion patterns. |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Get the HW to SMT conversion patterns. | |
| /// Get the Datapath to SMT conversion patterns. |
Comment on lines
52
to
58
| // Create free variables | ||
| SmallVector<Value, 2> newResults; | ||
| for (Value result : results) { | ||
| auto declareFunOp = rewriter.create<smt::DeclareFunOp>( | ||
| op.getLoc(), typeConverter->convertType(result.getType())); | ||
| newResults.push_back(declareFunOp.getResult()); | ||
| } |
| //CHECK-NEXT: %[[ADD012:.+]] = smt.bv.add %[[ADD01]], %[[PP2]] : !smt.bv<3> | ||
| //CHECK-NEXT: %[[P:.+]] = smt.eq %[[MUL]], %[[ADD012]] : !smt.bv<3> | ||
| //CHECK-NEXT: smt.assert %[[P]] | ||
| //CHECK-NEXT: hw.output %[[PP0_BV:.+]], %[[PP1_BV:.+]], %[[PP2_BV:.+]] : i3, i3, i3 |
Contributor
There was a problem hiding this comment.
Suggested change
| //CHECK-NEXT: hw.output %[[PP0_BV:.+]], %[[PP1_BV:.+]], %[[PP2_BV:.+]] : i3, i3, i3 | |
| //CHECK-NEXT: hw.output %[[PP0_BV]], %[[PP1_BV]], %[[PP2_BV]] : i3, i3, i3 |
| // CHECK-NEXT: %[[COMP0:.+]] = smt.declare_fun : !smt.bv<4> | ||
| // CHECK-NEXT: %[[COMP0_BV:.+]] = builtin.unrealized_conversion_cast %[[COMP0]] : !smt.bv<4> to i4 | ||
| // CHECK-NEXT: %[[COMP1:.+]] = smt.declare_fun : !smt.bv<4> | ||
| // CHECK-NEXT: %[[COMP1_BV:.+]] = builtin.unrealized_conversion_cast %7 : !smt.bv<4> to i4 |
Contributor
There was a problem hiding this comment.
Suggested change
| // CHECK-NEXT: %[[COMP1_BV:.+]] = builtin.unrealized_conversion_cast %7 : !smt.bv<4> to i4 | |
| // CHECK-NEXT: %[[COMP1_BV:.+]] = builtin.unrealized_conversion_cast %[[COMP1]] : !smt.bv<4> to i4 |
Comment on lines
27
to
32
| //CHECK-NEXT: %[[PP0:.+]] = smt.declare_fun : !smt.bv<3> | ||
| //CHECK-NEXT: %[[PP0_BV:.+]] = builtin.unrealized_conversion_cast %3 : !smt.bv<3> to i3 | ||
| //CHECK-NEXT: %[[PP1:.+]] = smt.declare_fun : !smt.bv<3> | ||
| //CHECK-NEXT: %[[PP1_BV:.+]] = builtin.unrealized_conversion_cast %5 : !smt.bv<3> to i3 | ||
| //CHECK-NEXT: %[[PP2:.+]] = smt.declare_fun : !smt.bv<3> | ||
| //CHECK-NEXT: %[[PP2_BV:.+]] = builtin.unrealized_conversion_cast %7 : !smt.bv<3> to i3 |
Contributor
There was a problem hiding this comment.
Suggested change
| //CHECK-NEXT: %[[PP0:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP0_BV:.+]] = builtin.unrealized_conversion_cast %3 : !smt.bv<3> to i3 | |
| //CHECK-NEXT: %[[PP1:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP1_BV:.+]] = builtin.unrealized_conversion_cast %5 : !smt.bv<3> to i3 | |
| //CHECK-NEXT: %[[PP2:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP2_BV:.+]] = builtin.unrealized_conversion_cast %7 : !smt.bv<3> to i3 | |
| //CHECK-NEXT: %[[PP0:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP0_BV:.+]] = builtin.unrealized_conversion_cast %[[PP0]] : !smt.bv<3> to i3 | |
| //CHECK-NEXT: %[[PP1:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP1_BV:.+]] = builtin.unrealized_conversion_cast %[[PP1]] : !smt.bv<3> to i3 | |
| //CHECK-NEXT: %[[PP2:.+]] = smt.declare_fun : !smt.bv<3> | |
| //CHECK-NEXT: %[[PP2_BV:.+]] = builtin.unrealized_conversion_cast %[[PP2]] : !smt.bv<3> to i3 |
uenoku
reviewed
Jul 10, 2025
| #include "circt/Conversion/DatapathToSMT.h" | ||
| #include "circt/Conversion/HWToSMT.h" | ||
| #include "circt/Dialect/Datapath/DatapathOps.h" | ||
| #include "mlir/Dialect/Func/IR/FuncOps.h" |
uenoku
reviewed
Jul 11, 2025
include/circt/Conversion/Passes.td
Outdated
| def ConvertDatapathToSMT : Pass<"convert-datapath-to-smt"> { | ||
| let summary = "Convert datapath ops to SMT ops"; | ||
| let dependentDialects = [ | ||
| "mlir::smt::SMTDialect", "hw::HWDialect", "mlir::func::FuncDialect" |
Member
There was a problem hiding this comment.
hw and func would be not necessary
uenoku
approved these changes
Jul 11, 2025
| rewriter.create<smt::BVAddOp>(op.getLoc(), operandRunner, operand); | ||
|
|
||
| // Create free variables | ||
| SmallVector<Value, 2> newResults; |
Member
There was a problem hiding this comment.
nit:
Suggested change
| SmallVector<Value, 2> newResults; | |
| SmallVector<Value, 2> newResults; | |
| newResults.reserve(results.size()); |
Contributor
Author
|
Comments addresssed and ready to merge when someone gets a chance please! |
Contributor
|
Awesome thanks! Landed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To verify correctness of transformations involving datapath operations, include a lowering from datapath to SMT. Will later be integrated into circt-lec to enable verification of these operators. Each operator satisfied a contract, rather than providing a precise semantics for every operator. This is because the datapath operators return values in redundant number representations, meaning there are many valid implementations.
For example:
Will be verified by introducing free variables for each return value (%0#0, %0#1) then asserting that the sum of the associated free variables is equal to the sum of the inputs:
assert(%0#0 + %0#1 == %a + %b + %c).Whilst this is encoded as an assert it really represents an assumption that must be satisfied by a valid implementation of datapath.compress.