[Comb] Enable cross-block folds on extract/concat/array_create(mux) #8611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-enable the canonicalizers and constant folders for `comb.extract`, `comb.concat`, and arrays of `comb.mux` that have operands defined in different blocks. Also remove the `hasOperandsOutsideOfBlock` function which is no longer needed.
uenoku
approved these changes
Jun 27, 2025
Member
uenoku
left a comment
uenoku
left a comment
There was a problem hiding this comment.
Awesome, thank you for cleaning this up!
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
…8611) Re-enable the canonicalizers and constant folders for `comb.extract`, `comb.concat`, and arrays of `comb.mux` that have operands defined in different blocks. Also remove the `hasOperandsOutsideOfBlock` function which is no longer needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-enable the canonicalizers and constant folders for
comb.extract,comb.concat, and arrays ofcomb.muxthat have operands defined in different blocks.Also remove the
hasOperandsOutsideOfBlockfunction which is no longer needed.