[FIRRTL] Move all annotations in inject-dut-hier #8596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/firrtl-inject-dut-hier-move-annotations
branch
from
676c048 to
2b1c2a9
Compare
seldridge
force-pushed
the
dev/seldridge/firrtl-inject-dut-hier-move-annotations
branch
3 times, most recently
from
dcd5214 to
89d7f8a
Compare
Refactor the InjectDUTHierarchy pass to not introduce the notion of a `newDUT` variable. This only confuses things. Instead setup the DUT and its internal wrapper immediately and then reuse these terms in all places. Signed-off-by: Schuyler Eldridge <[email protected]>
Change FIRRTL's inject-dut-hier pass to move all annotations onto the wrapper [^1] when in `moveDut=true` mode. Additionally, when in this mode, the WRAPPER will be named using the `name` field of this pass' controlling annotation. Previously, this would only move the `MarkDUTAnnotation` when operating in this mode. This fixes an internal issue where Object Model paths were not being updated when using this pass in `moveDut=true` mode. [^1]: This is using the terminology of the pass which views this as taking all the logic inside the original DUT and shoving it into a wrapper instantiated inside the DUT. When in `moveDut=true` mode, it is more natural to think of the pass as creating a wrapper around the original DUT. However, to adopt this alternative terminology would be modal. I.e., "wrapper" would mean something different when in `movedDut=true` mode which would be confusing. Signed-off-by: Schuyler Eldridge <[email protected]>
seldridge
force-pushed
the
dev/seldridge/firrtl-inject-dut-hier-move-annotations
branch
from
89d7f8a to
4f348d2
Compare
seldridge
deleted the
dev/seldridge/firrtl-inject-dut-hier-move-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change FIRRTL's inject-dut-hier pass to move all annotations onto the
wrapper 1 when in
moveDut=truemode. Previously, this would only movethe
MarkDUTAnnotation. This fixes an internal issue where Object Modelpaths were not being updated when using this pass in
moveDut=truemode.Other NFC chagnes:
newDUTvariable. This only confuses things. Instead setup the DUT and itsinternal wrapper immediately and then reuse these terms in all places.
behavior inside FIRRTL's inject-dut-hier pass. Previously this was the "new"
test which duplicated a now deleted test.
FIRRTL pass. This test started out as the original test, then a copy of it
was created that used a different NLA format, then the test became a true
duplicate.
Footnotes
This is using the terminology of the pass which views this as taking
all the logic inside the original DUT and shoving it into a wrapper
instantiated inside the DUT. When in
moveDut=truemode, it is morenatural to think of the pass as creating a wrapper around the original
DUT. However, to adopt this alternative terminology would be modal.
I.e., "wrapper" would mean something different when in
movedDut=truemode which would be confusing. ↩