[firtool] Enable WireElimination pass #8594
Merged
+25
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Jun 26, 2025
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
LGTM
Have you checked the Verilog diff on any internal designs?
uenoku
force-pushed
the
dev/hidetou/enable-wire
branch
from
28cb185 to
c806493
Compare
Member
Author
|
Diff is massive because of naming changes and more optimization opportunities. Verified LEC on small core (but probably LEC wouldn't be verified in general because of register optimizations), and manually looked at diff on large core and the change looks reasonable. Created a flag to disable the pass so we can turn off the pass when there is an issue. |
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
This adds EliminateWiresPass before IMCP to introduce a lot of more optimization opportunities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds EliminateWiresPass before IMCP