[FIRRTL] Make CatPrimOp variadic #8557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch converts CatPrimOp from a binary operation to a variadic operation that can accept multiple operands. The change is mostly straight forward: - Redefining CatPrimOp in FIRRTLExpressions.td to accept variadic inputs - Updating the fold method to handle multiple operands - Modifying canonicalization patterns to work with the new variadic form (https://mlir.llvm.org/docs/DeclarativeRewrites/#supporting-variadic-ops) - Updating the FIRRTL to HW lowering to handle variadic concatenation - Adjusting the FIREmitter to properly handle the new operation - Updating the FIRRTL visitor to handle CatPrimOp separately - Adding tests for the variadic concatenation operation This change allows for more efficient representation of multi-operand concatenations without needing to create a chain of binary operations.
uenoku
force-pushed
the
dev/hidetou/concat
branch
from
0022090 to
8fb7354
Compare
seldridge
reviewed
Jun 11, 2025
uenoku
force-pushed
the
dev/hidetou/concat
branch
from
60a476e to
c84dd0a
Compare
TaoBi22
pushed a commit
to TaoBi22/circt
that referenced
this pull request
Jul 17, 2025
This patch converts CatPrimOp from a binary operation to a variadic operation that can accept multiple operands. The change is mostly mechanical: - Updating the fold method to handle multiple operands - Modifying canonicalization patterns to work with the new variadic form (https://mlir.llvm.org/docs/DeclarativeRewrites/#supporting-variadic-ops) - Updating the FIRRTL to HW lowering to handle variadic concatenation - Adjusting the FIREmitter FIRRTLVistior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch converts CatPrimOp from a binary operation to a variadic operation that can accept multiple operands. The change is mostly mechanical: