Update to C++17 #318
Closed
Update to C++17 #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckendrick
approved these changes
Nov 18, 2025
IdoAkkerman
reviewed
Nov 20, 2025
| const char *device_config = "cpu"; | ||
| bool visualization = false; | ||
| bool visit = false; | ||
| bool use_visit = false; |
Collaborator
There was a problem hiding this comment.
removing using namespace std; will likely also do the trick.
I think using namespace std; is considered bad practice, exactly for the reason it causes problems here... I also use it quite often :), just saying..
Collaborator
There was a problem hiding this comment.
A good compromise might be:using namespace std::cout
According to:
https://www.geeksforgeeks.org/cpp/using-namespace-std-considered-bad-practice/
Collaborator
|
Closing since these changes are added in #320. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building with MFEM now requires C++17, and the necessary changes are made in this PR.