Conversation
Instead of quittting on error, retry. Check for context cancellation which indicates a swap or disconnect. Also lazily instantiate the output reader per retry, so we aren't blasting out 5+ seconds worth of buffered data after each retry.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3708 +/- ##
===================================================
- Coverage 31.62285% 31.60888% -0.01397%
===================================================
Files 157 157
Lines 47472 47474 +2
===================================================
- Hits 15012 15006 -6
- Misses 31566 31573 +7
- Partials 894 895 +1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
mjh1
approved these changes
Aug 15, 2025
ad-astra-video
pushed a commit
that referenced
this pull request
Aug 20, 2025
Instead of quittting on error, retry. Check for context cancellation which indicates a swap or disconnect. Also lazily instantiate the output reader per retry, so we aren't blasting out 5+ seconds worth of buffered data after each retry.
ad-astra-video
pushed a commit
that referenced
this pull request
Aug 20, 2025
Instead of quittting on error, retry. Check for context cancellation which indicates a swap or disconnect. Also lazily instantiate the output reader per retry, so we aren't blasting out 5+ seconds worth of buffered data after each retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of quitting on error, retry. Clean exits are rare; we almost always get an error.
Check for context cancellation which indicates a swap or disconnect. Quit on those. We already
check for disconnected input after the sleep.
This helps fix the case where the output disconnects but the rest of the processing keeps going.
Also lazily instantiate the output reader per retry, so we aren't blasting out 5+ seconds worth of
buffered data after each retry.