Skip to content

ai/live: Retry ffmpeg more often.#3708

Merged
mjh1 merged 1 commit intomasterfrom
ja/retry-ffmpeg
Aug 15, 2025
Merged

ai/live: Retry ffmpeg more often.#3708
mjh1 merged 1 commit intomasterfrom
ja/retry-ffmpeg

Conversation

@j0sh
Copy link
Copy Markdown
Collaborator

@j0sh j0sh commented Aug 14, 2025

Instead of quitting on error, retry. Clean exits are rare; we almost always get an error.

Check for context cancellation which indicates a swap or disconnect. Quit on those. We already
check for disconnected input after the sleep.

This helps fix the case where the output disconnects but the rest of the processing keeps going.

Also lazily instantiate the output reader per retry, so we aren't blasting out 5+ seconds worth of
buffered data after each retry.

Instead of quittting on error, retry.

Check for context cancellation which indicates a swap or disconnect.

Also lazily instantiate the output reader per retry, so we aren't
blasting out 5+ seconds worth of buffered data after each retry.
@j0sh j0sh requested review from leszko, mjh1 and victorges August 14, 2025 18:09
@github-actions github-actions bot added go Pull requests that update Go code AI Issues and PR related to the AI-video branch. labels Aug 14, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 14, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.60888%. Comparing base (5d4a57d) to head (1745781).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
server/ai_live_video.go 0.00000% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##              master       #3708         +/-   ##
===================================================
- Coverage   31.62285%   31.60888%   -0.01397%     
===================================================
  Files            157         157                 
  Lines          47472       47474          +2     
===================================================
- Hits           15012       15006          -6     
- Misses         31566       31573          +7     
- Partials         894         895          +1     
Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d4a57d...1745781. Read the comment docs.

Files with missing lines Coverage Δ
server/ai_live_video.go 0.00000% <0.00000%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mjh1 mjh1 merged commit 2042150 into master Aug 15, 2025
20 checks passed
@mjh1 mjh1 deleted the ja/retry-ffmpeg branch August 15, 2025 14:18
ad-astra-video pushed a commit that referenced this pull request Aug 20, 2025
Instead of quittting on error, retry.

Check for context cancellation which indicates a swap or disconnect.

Also lazily instantiate the output reader per retry, so we aren't
blasting out 5+ seconds worth of buffered data after each retry.
ad-astra-video pushed a commit that referenced this pull request Aug 20, 2025
Instead of quittting on error, retry.

Check for context cancellation which indicates a swap or disconnect.

Also lazily instantiate the output reader per retry, so we aren't
blasting out 5+ seconds worth of buffered data after each retry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI Issues and PR related to the AI-video branch. go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants