ai/worker: Absorb ai-worker library#3345
Merged
Conversation
github-actions
bot
added
dependencies
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3345 +/- ##
===================================================
- Coverage 33.63244% 32.26037% -1.37207%
===================================================
Files 141 147 +6
Lines 37556 40573 +3017
===================================================
+ Hits 12631 13089 +458
- Misses 24202 26713 +2511
- Partials 723 771 +48
Continue to review full report in Codecov by Sentry.
|
victorges
force-pushed
the
vg/chore/ai-worker-to-go-livepeer
branch
from
17174ee to
a2f4e63
Compare
This commit renames the `ai_worker` file to better represent its role within the orchestrator side of the network stack, improving clarity and maintainability.
After offline discussion we realized it makes more sense as is. Kept some docs.
Cannot run it yet since ai-worker repo is out of sync.
Ported from original README in ai-worker repo
victorges
force-pushed
the
vg/chore/ai-worker-to-go-livepeer
branch
from
01eda1a to
732240c
Compare
victorges
force-pushed
the
vg/chore/ai-worker-to-go-livepeer
branch
4 times, most recently
from
e6c24e0 to
95830ae
Compare
victorges
force-pushed
the
vg/chore/ai-worker-to-go-livepeer
branch
from
95830ae to
695e81b
Compare
rickstaa
reviewed
Feb 3, 2025
| # Git reference to download the OpenAPI spec from, defaults to `main` branch. | ||
| # It can also be a simple git commit hash. e.g. `make ai_worker_codegen REF=c19289d` | ||
| REF ?= refs/heads/main | ||
| ai_worker_codegen: |
Member
There was a problem hiding this comment.
@victorges I assume this command is excluded from all to prevent unexpected breakage? If so, perhaps we should document it in the developer docs?
| PortBindings: nat.PortMap{ | ||
| containerPort: []nat.PortBinding{ | ||
| { | ||
| HostIP: "0.0.0.0", |
Contributor
There was a problem hiding this comment.
Could that be 127.0.0.1 to avoid exposing the ports out of the machine?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
This is to move the Go logic from
livepeer/ai-workerrepository into a separate packagein this repository (the only consumer).
This will allow
livepeer/ai-workerto be renamed toai-runnerand avoid anymaintenance confusion, keeping only the specific AI runner container logic on it.
Specific updates (required)
ai-workerworkerpackage (needs update after some PRs get merged there)go.moddependencyMakefilecommand to generaterunner.gen.goAPI bindingsdoc.gobased on the relevant README bits fromlivepeer/ai-workerHow did you test each of these updates (required)
If it builds it works. No code changes.
Does this pull request close any open issues?
No.
Checklist:
makeruns successfully./test.shpass