Skip to content

pm: lower avgGasPrice #2481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leszko merged 3 commits into from
Jul 11, 2022
Merged

pm: lower avgGasPrice #2481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
187a07d
pm: Lower `avgGasPrice`
leszko Jul 11, 2022
eefa358
Update avg gas price to 3 gwei
leszko Jul 11, 2022
c14d9ce
Update avg gas price to 3 gwei
leszko Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,6 @@

#### Orchestrator
- \#2493 cmd: Fix reward flag (@leszko)
- \#2481 Lower `avgGasPrice` to prevent dropping streams during the gas price spikes (@leszko)

#### Transcoder
7 changes: 3 additions & 4 deletions pm/recipient.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ var paramsExpiryBuffer = int64(1)

var evMultiplier = big.NewInt(100)

// Hardcode to 200 gwei
// Hardcode to 3 gwei
// TODO: Replace this hardcoded value by dynamically determining the average gas price during a period of time
var avgGasPrice = new(big.Int).Mul(big.NewInt(200), new(big.Int).Exp(big.NewInt(10), big.NewInt(9), nil))
var avgGasPrice = new(big.Int).Mul(big.NewInt(3), new(big.Int).Exp(big.NewInt(10), big.NewInt(9), nil))

// Recipient is an interface which describes an object capable
// of receiving tickets
Expand Down Expand Up @@ -300,8 +300,7 @@ func (r *recipient) faceValue(sender ethcommon.Address) (*big.Int, error) {
// because there is a good chance that the current gasPrice will come back down by the time a winning ticket is received
// and needs to be redeemed.
// For now, avgGasPrice is hardcoded. See the comment for avgGasPrice for TODO information.
// Use || here for lazy evaluation. If the first clause is true we ignore the second clause.
if !(faceValue.Cmp(txCost) >= 0 || faceValue.Cmp(r.txCostWithGasPrice(avgGasPrice)) >= 0) {
if faceValue.Cmp(txCost) < 0 && faceValue.Cmp(r.txCostWithGasPrice(avgGasPrice)) < 0 {
return nil, errInsufficientSenderReserve
}

Expand Down