Merged
Conversation
yondonfu
approved these changes
Jan 27, 2022
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
Great use of conditional build tags!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Display
Ctrl+Zinstead ofCtrl+Dfor Windows.Specific updates (required)
N/A
How did you test each of these updates (required)
Ctrl+Zis printed (link)Does this pull request close any open issues?
fix #2210
Checklist:
makeruns successfully./test.shpass