Skip to content

transcoder: Enable B-frames in Nvidia encoder#1944

Merged
jailuthra merged 2 commits intomasterfrom
jai/bframes-gpu
Jul 7, 2021
Merged

transcoder: Enable B-frames in Nvidia encoder#1944
jailuthra merged 2 commits intomasterfrom
jai/bframes-gpu

Conversation

@jailuthra
Copy link
Copy Markdown
Contributor

@jailuthra jailuthra commented Jul 1, 2021

What does this pull request do? Explain your changes. (required)

Pull in changes from livepeer/lpms#243 around enabling B-frames for Nvidia encoder

Specific updates (required)

see commits

How did you test each of these updates (required)

Local testing with pushing segments in with the following transcoding options, and verifying output renditions have the expected H264 profiles/B-frames.

[
{
  "name": "240p0",
  "fps": 0,
  "profile": "H264High",
  "bitrate": 250000,
  "width": 426,
  "height": 240
},
{
  "name": "360p0",
  "fps": 0,
  "profile": "H264ConstrainedHigh",
  "bitrate": 800000,
  "width": 640,
  "height": 360
},
{
  "name": "480p0",
  "fps": 0,
  "profile": "H264Main",
  "bitrate": 1600000,
  "width": 854,
  "height": 480
},
{
  "name": "720p0",
  "fps": 0,
  "profile": "H264Baseline",
  "bitrate": 3000000,
  "width": 1280,
  "height": 720
}
]

Does this pull request close any open issues?

Fixes #1941

Checklist:

@darkdarkdragon darkdarkdragon force-pushed the it/return-zero-frame branch 2 times, most recently from e97d743 to 41a2c60 Compare July 6, 2021 19:22
Base automatically changed from it/return-zero-frame to master July 6, 2021 19:59
@jailuthra jailuthra marked this pull request as ready for review July 7, 2021 07:41
Copy link
Copy Markdown
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after addressing the CHANGELOG_PENDING comment.

@jailuthra jailuthra merged commit 226447a into master Jul 7, 2021
@yondonfu yondonfu deleted the jai/bframes-gpu branch July 7, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump LPMS to 0da8cb6

2 participants