http push: return 422 for non-retryable errors#1934
Merged
darkdarkdragon merged 2 commits intomasterfrom Jun 29, 2021
Merged
Conversation
darkdarkdragon
force-pushed
the
it/invalid-request
branch
from
f897f18 to
026e7f8
Compare
yondonfu
reviewed
Jun 29, 2021
darkdarkdragon
force-pushed
the
it/invalid-request
branch
from
d26e38a to
7795e90
Compare
darkdarkdragon
force-pushed
the
it/invalid-request
branch
from
7795e90 to
cf3cbbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
In HTTP push handler returns 422 status code for non-retryable errors
Specific updates (required)
How did you test each of these updates (required)
unit test
Does this pull request close any open issues?
Fixes #1927
Checklist:
makeruns successfully./test.shpass