Serialize writes of JSON playlist#1932
Merged
darkdarkdragon merged 3 commits intomasterfrom Jul 22, 2021
Merged
Conversation
4e0618e to
f7ae625
Compare
9f70115 to
9dd88db
Compare
jailuthra
reviewed
Jul 13, 2021
yondonfu
requested changes
Jul 19, 2021
f0c59f4 to
980d789
Compare
yondonfu
reviewed
Jul 22, 2021
4a25547 to
5382941
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Fixes
Error saving json playlisterror.We're making a lot of writes (to object store) to same json playlist file during stream.
Each write starts in own goroutine, so often new writes starts before previous completed.
In that case request to Google Cloud Storage often takes more than 10s, which is our timeout.
This PR fixes problem by serializing write requests.
Specific updates (required)
OvewriteQueueclass that serializes writes to the same file in OS.OvewriteQueuefor writing JSON playlists.How did you test each of these updates (required)
Unit tests
Does this pull request close any open issues?
Fixes #1924
Checklist:
makeruns successfully./test.shpass