pm: increase TicketParams expiration to 10 blocks#1873
Merged
kyriediculous merged 1 commit intomasterfrom May 11, 2021
Merged
Conversation
yondonfu
requested changes
May 5, 2021
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
Looks good. Just missing a changelog entry.
kyriediculous
force-pushed
the
nv/tp-expiry
branch
from
914e5ec to
5d60bdf
Compare
yondonfu
approved these changes
May 6, 2021
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
Minor comment about categorizing the changelog entry, but feel free to address prior to merge.
LGTM
CHANGELOG_PENDING.md
Outdated
|
|
||
| - \#1848 Use fee cut instead of fee share for user facing language in the CLI (@kyriediculous) | ||
| - \#1854 Allow to pass region in the custom s3 storage URL (@darkdarkdragon) | ||
| - \#1873 Increase TicketParams expiration to 10 blocks (@kyriediculous) |
Member
There was a problem hiding this comment.
I think this should be under "Orchestrator" since it is an orchestrator implementation detail.
kyriediculous
force-pushed
the
nv/tp-expiry
branch
from
5d60bdf to
21dc7de
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Increase the ticketparams expiration to 10 blocks
Does this pull request close any open issues?
Fixes #1872
Checklist:
makeruns successfully./test.shpass