cmd,eth: remove deprecated flags#1838
Merged
kyriediculous merged 3 commits intomasterfrom Apr 13, 2021
Merged
Conversation
kyriediculous
force-pushed
the
nv/remove-flags
branch
from
a16f5c2 to
adea7d1
Compare
kyriediculous
force-pushed
the
nv/remove-flags
branch
from
adea7d1 to
2344e59
Compare
yondonfu
requested changes
Apr 12, 2021
Member
yondonfu
left a comment
yondonfu
left a comment
There was a problem hiding this comment.
Looks like one of the tests in test_args.sh failed likely due to a reason described in one of my review comments.
kyriediculous
force-pushed
the
nv/remove-flags
branch
from
2344e59 to
c963aba
Compare
yondonfu
reviewed
Apr 12, 2021
kyriediculous
force-pushed
the
nv/remove-flags
branch
from
c9613c1 to
300d589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Remove deprecated flags
Specific updates (required)
gasPriceflagGetGasInfocodeHow did you test each of these updates (required)
Ran unit tests
Does this pull request close any open issues?
Fixes #1798
Checklist:
makeruns successfully./test.shpass