Skip to content

Fix LB transcoder race condition around session-cleanup#1775

Merged
jailuthra merged 3 commits intomasterfrom
jai/lbrace
Feb 25, 2021
Merged

Fix LB transcoder race condition around session-cleanup#1775
jailuthra merged 3 commits intomasterfrom
jai/lbrace

Conversation

@jailuthra
Copy link
Copy Markdown
Contributor

@jailuthra jailuthra commented Feb 24, 2021

What does this pull request do? Explain your changes. (required)

Ensure that no segments are left hanging since we increased the LB channel size in 882ed38

Specific updates (required)

How did you test each of these updates (required)

  • Run the test case in 415c1c0 to reproduce hanging behaviour
  • Run the test case again after the fix to verify hanging behaviour does not happen anymore

Does this pull request close any open issues?

Fixes #1750

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Copy Markdown
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a few minor comments relating to the tests.

Copy link
Copy Markdown
Contributor

@kyriediculous kyriediculous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me pending Yondon's comments 👍

@jailuthra jailuthra requested a review from yondonfu February 24, 2021 21:00
Copy link
Copy Markdown
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after squashing

@jailuthra jailuthra merged commit c0b4133 into master Feb 25, 2021
@kyriediculous kyriediculous deleted the jai/lbrace branch February 25, 2021 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LB transcoder race condition for segment that comes in really fast for the same session after a LPMS transcode error

3 participants