Skip to content

Flush recording JSON playlist after changing it#1766

Merged
darkdarkdragon merged 2 commits intomasterfrom
it/flash-record
Feb 18, 2021
Merged

Flush recording JSON playlist after changing it#1766
darkdarkdragon merged 2 commits intomasterfrom
it/flash-record

Conversation

@darkdarkdragon
Copy link
Copy Markdown
Contributor

What does this pull request do? Explain your changes. (required)
Flushed JSON playlist used in recording after it was modified.

Specific updates (required)
Move around FlushRecord call.

How did you test each of these updates (required)
Manually.

Does this pull request close any open issues?

Checklist:

  • README and other documentation updated
  • Node runs in OSX and devenv
  • All tests in ./test.sh pass

Copy link
Copy Markdown
Member

@yondonfu yondonfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkdarkdragon darkdarkdragon merged commit ccbd52e into master Feb 18, 2021
@darkdarkdragon darkdarkdragon deleted the it/flash-record branch February 18, 2021 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants