Feat/decorators pt2 #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarscher
force-pushed
the
feat/decorators-pt2
branch
from
ff3742e to
6e28a89
Compare
Member
|
I think @ValidateOptions was working as the validator for the constructor in my original commit in this branch. Not sure how but I think that worked fine (don't know why it wasn't working last night). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a bunch of messing around with decorators. I haven't been able to get the context param to be anything but
undefinedwhen I run vitest. I tried removing the experimental decorator flags thinking they conflict with the new implementation. But I still couldn't get the context param to be populated.I tried making a generic validate decorator for constructors or methods. It seems to work... but it probably calls new on the method thinking it's a class because context.kind is undefined.