Skip to content

Small fixes in Agent I/O #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev-1.0
Choose a base branch
from
Open

Small fixes in Agent I/O #574

wants to merge 3 commits into from

Conversation

Shubhrakanti
Copy link
Contributor

Updated base don feedback on #573

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ea0947c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Shubhrakanti Shubhrakanti changed the base branch from main to dev-1.0 July 23, 2025 22:15
@Shubhrakanti Shubhrakanti requested a review from toubatbrian July 23, 2025 22:15
Shubhrakanti
Shubhrakanti commented Jul 23, 2025
View reviewed changes
agents/src/voice/agent_session.ts
@@ -327,17 +327,18 @@ export class AgentSession<
}

// -- User changed input/output streams/sinks --
private onAudioInputChanged(): void {
private onAudioInputChanged = (): void => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

event listeners should be arrow functions

Shubhrakanti
Shubhrakanti commented Jul 23, 2025
View reviewed changes
agents/src/voice/agent_activity.ts
@@ -358,7 +353,9 @@ export class AgentActivity implements RecognitionHooks {
}

detachAudioInput(): void {
this.audioStream.detachSource();
if (this.audioStream.isSourceSet) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be a check here right?

toubatbrian
toubatbrian reviewed Jul 24, 2025
View reviewed changes
agents/src/voice/agent_activity.ts
}

updateAudioInput(audioStream: ReadableStream<AudioFrame>): void {
this.detachAudioInput();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested if it work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a check if (this.audioStream.isSourceSet)?

toubatbrian
toubatbrian reviewed Jul 24, 2025
View reviewed changes
Copy link
Contributor

@toubatbrian toubatbrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toubatbrian toubatbrian toubatbrian left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shubhrakanti @toubatbrian