feat: Display error message in the UI if SSH key management is disabled (#13875)

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13875
Reviewed-by: 0ko <0ko@noreply.codeberg.org>

Author: luggesexe

options/locale_next/locale_en-US.json

@@ -189,6 +189,7 @@
 	"keys.ssh.link": "SSH keys",
 	"keys.gpg.link": "GPG keys",
 	"keys.verify.token.hint": "The token is only valid for 1 minute. <a href=\"%[1]s\">Get a new one if it expired</a>.",
+	"keys.ssh.disabled": "SSH key management is disabled on this instance by an administrator.",
 	"admin.federation.federation": "Federation",
 	"admin.federation.hosts": "Hosts",
 	"admin.federation.hosts.title": "Federation hosts",

templates/user/settings/keys.tmpl

@@ -1,6 +1,10 @@
 {{template "user/settings/layout_head" (dict "ctxData" . "pageClass" "user settings sshkeys")}}
 	<div class="user-setting-content">
-		{{if not ($.UserDisabledFeatures.Contains "manage_ssh_keys")}}
+		{{if $.UserDisabledFeatures.Contains "manage_ssh_keys"}}
+			<div class="ui warning message">
+				<p>{{ctx.Locale.Tr "keys.ssh.disabled"}}</p>
+			</div>
+		{{else}}
 			{{template "user/settings/keys_ssh" .}}
 		{{end}}
 		{{template "user/settings/keys_principal" .}}

tests/integration/setting_test.go

@@ -12,6 +12,7 @@ import (
 	"forgejo.org/models/db"
 	"forgejo.org/models/unittest"
 	user_model "forgejo.org/models/user"
+	"forgejo.org/modules/container"
 	"forgejo.org/modules/setting"
 	"forgejo.org/modules/test"
 	"forgejo.org/modules/translation"
@@ -274,3 +275,40 @@ func TestAdminAvatarSizeNotice(t *testing.T) {
 		htmlDoc.doc.Find("form div:has(input[name=\"avatar\"]) .help").Text(),
 		"Custom avatar may not exceed 1 MiB in size or be larger than 4096x4096 pixels")
 }
+
+func TestSSHKeyManagementStatus(t *testing.T) {
+	defer tests.PrepareTestEnv(t)()
+	locale := translation.NewLocale("en-US")
+
+	t.Run("Enabled", func(t *testing.T) {
+		defer tests.PrintCurrentTest(t)()
+		session := loginUser(t, "user2")
+		req := NewRequest(t, "GET", "/user/settings/keys")
+		resp := session.MakeRequest(t, req, http.StatusOK)
+		htmlDoc := NewHTMLParser(t, resp.Body)
+
+		htmlDoc.AssertElement(t, "#add-ssh-button", true)
+
+		assert.NotContains(t,
+			htmlDoc.doc.Find(".user-setting-content .ui.warning.message").Text(),
+			locale.TrString("keys.ssh.disabled"),
+		)
+	})
+
+	t.Run("Disabled", func(t *testing.T) {
+		defer tests.PrintCurrentTest(t)()
+		defer test.MockVariableValue(&setting.Admin.UserDisabledFeatures, container.SetOf("manage_ssh_keys"))()
+
+		session := loginUser(t, "user2")
+		req := NewRequest(t, "GET", "/user/settings/keys")
+		resp := session.MakeRequest(t, req, http.StatusOK)
+		htmlDoc := NewHTMLParser(t, resp.Body)
+
+		htmlDoc.AssertElement(t, "#add-ssh-button", false)
+
+		assert.Contains(t,
+			htmlDoc.doc.Find(".user-setting-content .ui.warning.message").Text(),
+			locale.TrString("keys.ssh.disabled"),
+		)
+	})
+}