feat: use setting.AppName in ssh auth message (#13921)

Closes https://codeberg.org/forgejo/forgejo/issues/13907

This PR replaces hardcoded 'Forgejo' in ssh output with already existing `setting.AppName`. Also simplifies the switch case a bit, such that the template can be an i18n candidate later.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/13921
Reviewed-by: limiting-factor <limiting-factor@noreply.codeberg.org>

Author: Omkar P

cmd/serv.go

@@ -21,6 +21,7 @@ import (
 	asymkey_model "forgejo.org/models/asymkey"
 	git_model "forgejo.org/models/git"
 	"forgejo.org/models/perm"
+	user_model "forgejo.org/models/user"
 	"forgejo.org/modules/git"
 	"forgejo.org/modules/json"
 	"forgejo.org/modules/lfs"
@@ -138,6 +139,32 @@ func handleCliResponseExtra(extra private.ResponseExtra) error {
 	return nil
 }
 
+func getKeyCheckMessage(
+	key *asymkey_model.PublicKey, user *user_model.User, appName string,
+) string {
+	instanceName := "this Forgejo instance"
+	appNameParts := strings.Split(strings.TrimSpace(appName), " ")
+	if len(appNameParts) <= 2 {
+		instanceName = strings.Join(appNameParts, " ")
+	}
+
+	msgTmpl := "Hi there%s! You've successfully authenticated with the %s, but %s " +
+		"does not provide shell access.\nIf this is unexpected, please log in with password and " +
+		"setup %s under another user."
+	username := ""
+	var authenticatedWith string
+	switch key.Type {
+	case asymkey_model.KeyTypeDeploy:
+		authenticatedWith = "deploy key named " + key.Name
+	case asymkey_model.KeyTypePrincipal:
+		authenticatedWith = "principal " + key.Content
+	default:
+		username = ", " + user.Name
+		authenticatedWith = "key named " + key.Name
+	}
+	return fmt.Sprintf(msgTmpl, username, authenticatedWith, instanceName, instanceName)
+}
+
 func runServ(ctx context.Context, c *cli.Command) error {
 	ctx, cancel := installSignals(ctx)
 	defer cancel()
@@ -178,15 +205,7 @@ func runServ(ctx context.Context, c *cli.Command) error {
 		if err != nil {
 			return fail(ctx, "Key check failed", "Failed to check provided key: %v", err)
 		}
-		switch key.Type {
-		case asymkey_model.KeyTypeDeploy:
-			fmt.Println("Hi there! You've successfully authenticated with the deploy key named " + key.Name + ", but Forgejo does not provide shell access.")
-		case asymkey_model.KeyTypePrincipal:
-			fmt.Println("Hi there! You've successfully authenticated with the principal " + key.Content + ", but Forgejo does not provide shell access.")
-		default:
-			fmt.Println("Hi there, " + user.Name + "! You've successfully authenticated with the key named " + key.Name + ", but Forgejo does not provide shell access.")
-		}
-		fmt.Println("If this is unexpected, please log in with password and setup Forgejo under another user.")
+		fmt.Println(getKeyCheckMessage(key, user, setting.AppName))
 		return nil
 	} else if c.Bool("debug") {
 		log.Debug("SSH_ORIGINAL_COMMAND: %s", os.Getenv("SSH_ORIGINAL_COMMAND"))

cmd/serv_test.go

@@ -0,0 +1,77 @@
+// Copyright 2026 The Forgejo Authors. All rights reserved.
+// SPDX-License-Identifier: GPL-3.0-or-later
+
+package cmd
+
+import (
+	"testing"
+
+	asymkey_model "forgejo.org/models/asymkey"
+	user_model "forgejo.org/models/user"
+	"forgejo.org/modules/log"
+)
+
+func TestGetKeyCheckMessage(t *testing.T) {
+	for _, tt := range []struct {
+		name        string
+		key         *asymkey_model.PublicKey
+		user        *user_model.User
+		appName     string
+		expectedMsg string
+	}{
+		{
+			name: "deploy key",
+			key: &asymkey_model.PublicKey{
+				Type:    asymkey_model.KeyTypeDeploy,
+				Name:    "deploy-test-key",
+				Content: "key contents",
+			},
+			user: &user_model.User{
+				Name: "test-user",
+			},
+			appName: "Codeberg",
+			expectedMsg: "Hi there! You've successfully authenticated with the deploy key named " +
+				"deploy-test-key, but Codeberg does not provide shell access.\nIf this is " +
+				"unexpected, please log in with password and setup Codeberg under another user.",
+		},
+		{
+			name: "principal",
+			key: &asymkey_model.PublicKey{
+				Type:    asymkey_model.KeyTypePrincipal,
+				Name:    "principal-test-key",
+				Content: "key contents",
+			},
+			user: &user_model.User{
+				Name: "test-user",
+			},
+			appName: "Forgejo: Beyond coding. We forge.",
+			expectedMsg: "Hi there! You've successfully authenticated with the principal " +
+				"key contents, but this Forgejo instance does not provide shell access.\n" +
+				"If this is unexpected, please log in with password and setup this Forgejo " +
+				"instance under another user.",
+		},
+		{
+			name: "user",
+			key: &asymkey_model.PublicKey{
+				Type:    asymkey_model.KeyTypeUser,
+				Name:    "user-test-key",
+				Content: "key contents",
+			},
+			user: &user_model.User{
+				Name: "test-user",
+			},
+			appName: "Social Coding",
+			expectedMsg: "Hi there, test-user! You've successfully authenticated with the key " +
+				"named user-test-key, but Social Coding does not provide shell access.\n" +
+				"If this is unexpected, please log in with password and setup Social Coding " +
+				"under another user.",
+		},
+	} {
+		t.Run(tt.name, func(t *testing.T) {
+			gotMsg := getKeyCheckMessage(tt.key, tt.user, tt.appName)
+			if gotMsg != tt.expectedMsg {
+				log.Fatal("expected key success message '%s' but got '%s'.", tt.expectedMsg, gotMsg)
+			}
+		})
+	}
+}