Remove Litmus from runtime #3018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yes, I remember we had to put it back considering the effort of a migration |
jonalvarezz
approved these changes
Aug 26, 2024
Contributor
jonalvarezz
left a comment
jonalvarezz
left a comment
There was a problem hiding this comment.
lgtm
I agree that it is safer to do the Web3Network clean up in a more controlled set of changes, if any
silva-fj
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR removes Litmus runtime integration.
One thing that I'm not very sure is
Litmusin the Assertion Web3Network, I keep it for now for backwards compatibility while removing some of the usage (e.g. when calculating LIT balance).I'd like to remove it completely, but unsure about the consequence.
Did we have some problems when removing
SubstrateTestNetwork?Please take a look @jonalvarezz @higherordertech