Skip to content

Fix security issue for V4#2424

Merged
mbdavid merged 4 commits intolitedb-org:v4from
viveleltsi:bugfix/fix-security-issue
Jun 19, 2024
Merged

Fix security issue for V4#2424
mbdavid merged 4 commits intolitedb-org:v4from
viveleltsi:bugfix/fix-security-issue

Conversation

@viveleltsi
Copy link

@viveleltsi viveleltsi commented Feb 19, 2024

Fix the severity issue for the old v4 liteDB version.
The goal is to have a patch for application who cannot update to V5.

Because this is my first PR for this project I think my changes should be properly checked and validated.

fix #2418

PS: This branch should not be merged on master but probably stay on a fix branch.

@mbdavid
Copy link
Collaborator

mbdavid commented Feb 19, 2024

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

@viveleltsi
Copy link
Author

Hi @viveleltsi, thanks for your code. Your v4 source, did you get from v4 branch or from v4.1.4 tag?

Hello ! Thank you for your response. My branch was created on the v4.1.4 tag. (commit 918b650).
Would you like me to try rebasing it on the v4 branch ? (Sorry I didn't saw this branch :S )

@viveleltsi viveleltsi force-pushed the bugfix/fix-security-issue branch from d3182c2 to 3f7eac9 Compare February 20, 2024 08:19
@viveleltsi
Copy link
Author

I rebase my branch onto the V4 branch (commit 46a8387) and I rebuild it and run the unit testing. It's all good.

@mbdavid
Copy link
Collaborator

mbdavid commented Feb 21, 2024

Nice! Thanks.... Could you create a pull request for v4 branch? Than I will create a new tag for this new release

@viveleltsi viveleltsi changed the base branch from master to v4 February 21, 2024 06:40
@viveleltsi
Copy link
Author

Yes of course. I updated this PR to target the v4 branch.

@viveleltsi
Copy link
Author

@mbdavid I updated the PR to the v4 branch :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[QUESTION] Is it possible to fix the vulnerability for the v4

2 participants