Change return type of ILiteRepository.Insert to match ILiteDatabase.Insert#2260
Merged
mbdavid merged 1 commit intolitedb-org:masterfrom Mar 9, 2023
Merged
Conversation
…nsert, and the documentation
mahop-net
reviewed
Dec 15, 2022
mahop-net
left a comment
mahop-net
left a comment
There was a problem hiding this comment.
Summary should be changed accordingly.
If not accepted summary should also be changed... :-)
Author
The summary as-is notes the method returns the ID - so what change is needed if the PR is accepted? |
|
OK, it really returns the ID - sorry I thought BsonValue holds the complete document, but it is only the ID... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation of ILiteRepository.Insert implied it returns the ID of the insert, but it returned void
Changed to make this API consistent