Restore target:esnext to samples tsconfig #582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression from #560 where we accidentally dropped from
"target": "esnext"
to"target": "es2020"
in thetsconfig.json
for sample files (I made a commontsconfig.base.json
which defaults toes2020
but forgot to override that in the samples one). We wantesnext
output for samples because we want to emit standard static class fields (note that@lit/ts-transformers
switches instance class field initializers to be constructor-initialized if they are decorated with@property
, to avoid that incompatibility).Current regressed state:
With fix: