initial tested version #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested all the clients I initially went into this wanting prism launcher as it is truly open source but its login flow was very hard to docker automate (needs minecraft client and template pre-installed) and it does not behave properly in Docker.
Curseforge and just the raw minecraft app were doable but the workflow of a user just logging into their microsoft account from within the app like this could not be matched by the other stuff.
Only downside is SDL full spin on CPU only servers, you can run everything but you will be churning your cores, I added a note about using a GPU in the application setup.
Other than that tested many different popular modpacks and no issues, this one is pending an input fix here in selkies for the weekend waterfall:
selkies-project/selkies@0c04b8b