Fix input method support for CJK languages in menu search and run dialog #13029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements proper input method (IME) support that was missing since the Clutter API migration in Cinnamon 5.0+. The original inputMethod.js file created during the 2021 API transition contained only empty method stubs, causing input method frameworks (ibus, fcitx, nimf, kime, xim, etc.) to fail in menu search boxes and Alt+F2 run dialogs. Changes: - Implement GTK IMMulticontext integration for universal IME support - Add Clutter to GDK event conversion for proper key event handling - Implement preedit text display and management for composition - Add proper focus handling and input method state management - Set up client window and cursor location for IME positioning Fixes multiple long-standing issues: - Menu search box not accepting CJK input (Korean, Japanese, Chinese) - Alt+F2 run dialog not supporting input method switching - All major Linux input method frameworks affected Closes: linuxmint#11115, linuxmint#11610, linuxmint#11713 Tested-by: HamoniKR team with Korean input (nimf, ibus, fcitx)
|
Hi thanks for this, but there is already a pending pull request (along with related changes in other packages). Testing welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements proper input method (IME) support that was missing since the Clutter API migration in Cinnamon 5.0+. The original inputMethod.js file created during the 2021 API transition contained only empty method stubs, causing input method frameworks (ibus, fcitx, nimf, kime, xim, etc.) to fail in menu search boxes and Alt+F2 run dialogs.
Changes:
Fixes multiple long-standing issues:
Closes: #11115, #11610, #11713
Tested-by: HamoniKR team with Korean input (nimf, ibus, fcitx)